bsd: Pass '-W' to netstat for full interface names on FreeBSD #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @mutemule ! We will review and test. |
| platf = sys.platform | ||
|
|
||
| # FreeBSD's netstat truncates device names unless you pass '-W' | ||
| if Platform.is_freebsd(platf): |
There was a problem hiding this comment.
You can use directly Platform.is_freebsd() 😉
|
Thanks again @mutemule , if you could just look at the few modifications I suggested and rebase that on master so that it can run the new Travis test suite that would be amazing! Looking forward to seeing this on a future agent release!! |
|
Merged in #1300, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
netstaton FreeBSD only shows the first five characters of an interfaced name, and truncates the rest. So following the standard VLAN naming convention (<iface>.<vlan_id>), we have interface names likere1.200,re1.210, andre1.220. These are seen as a single interface calledre1.2by the agent.Unfortunately, at least OpenBSD has a differing interpretation of
-Wfor netstat, so limit the additional flag to just FreeBSD for now. I don't have access to any other BSD to test right now. I'm also not sure this is the best way to handle this, but it seemed reasonably clean.