Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cassandra] Add read and write latency ColumnFamily metrics #2483

Merged
merged 1 commit into from Sep 7, 2016

Conversation

sethrosenblum
Copy link
Contributor

Read and Write latency are not only a way to figure out how long it takes to run the specified operation against the given columnfamily, the count metric is also the only way to figure out how often we're reading from and writing to a column family.

cc @johnaxel

@sethrosenblum sethrosenblum changed the title [cassandra] Add read and write latency ColumnFamily metrics [cassandra][skip ci] Add read and write latency ColumnFamily metrics May 9, 2016
@johnaxel
Copy link
Contributor

This is a very useful addition but I think it would balloon the number of metrics collected if we don't filter somewhat. For Cassandra 2.2 at least, ReadLatency and WriteLatency each contain 17 separate metric attributes, which would be collected for every CF. So each column family will add ~30 metrics to the JMX pile. I think we could filter this down to just grab a couple key metrics from this grouping for each CF, though.

@olivielpeau
Copy link
Member

I agree that it'd be better to scope the filter to the most useful attributes only. @sethrosenblum any insight on that? :)

(assigning to @yannmh)

@olivielpeau olivielpeau added this to the Triage milestone May 10, 2016
@olivielpeau olivielpeau assigned yannmh and unassigned olivielpeau May 10, 2016
Read and Write latency are not only a way to figure out how long it takes to run the specified operation against the given columnfamily, the count metric is also the only way to figure out how often we're reading from and writing to a column family.
This adds the following attributes for read and write latency:
- Count (frequency of reads/writes)
- Mean latency
- 99th percentile latency
- Max latency
@sethrosenblum sethrosenblum force-pushed the seth/cassandra-latency-metrics branch from c3ac0d8 to f5dca28 Compare June 14, 2016 21:27
@sethrosenblum
Copy link
Contributor Author

@johnaxel @olivielpeau I narrowed the attributes to Count (the most important), Mean, 99p and Max. We could also swap 99p for 95p or drop them altogether if that makes more sense.

@olivielpeau olivielpeau modified the milestones: 5.9.0, Triage Jun 15, 2016
@truthbk truthbk modified the milestones: 5.10.0, 5.9.0 Aug 12, 2016
@yannmh yannmh modified the milestones: 5.9.0, 5.10.0 Sep 6, 2016
@yannmh yannmh changed the title [cassandra][skip ci] Add read and write latency ColumnFamily metrics [cassandra] Add read and write latency ColumnFamily metrics Sep 6, 2016
@yannmh
Copy link
Member

yannmh commented Sep 7, 2016

Looks good to me ✅

On Cassandra 2.1, the change creates 8 additional new metrics per (keyspace,scope).

@yannmh yannmh merged commit e310f97 into master Sep 7, 2016
@yannmh yannmh deleted the seth/cassandra-latency-metrics branch September 7, 2016 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants