[kubernetes] add namespace tag to kubernetes.pods.running #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remh
reviewed
Oct 24, 2016
| @@ -326,22 +326,25 @@ def _update_pods_metrics(self, instance, pods): | |||
| "ReplicaSet", | |||
| ] | |||
|
|
|||
| controllers_map = defaultdict(int) | |||
| controllers_map = defaultdict(lambda: {'count': 0, 'namespace': None}) | |||
There was a problem hiding this comment.
This is a weird datastructure you use.
You should keep a defaultdict(int) (or a collections.Counter) where the keys would be a tuple (namespace, controller)
remh
suggested changes
Oct 24, 2016
hkaj
force-pushed
the
haissam/k8s-add-namespace-tag
branch
from
b004906
to
8ee6968
Compare
remh
approved these changes
Nov 2, 2016
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Add the
kube_namespacetag tokubernetes.pods.running.Motivation
User request, it makes aggregation easier and more useful.
Testing Guidelines
Relevant tests have been update.
Additional Notes
We should update the
kube_replication_controllertag name (must be done carefully as it will break things for users relying on it). It used to be accurate but now pods can be created by daemon sets, jobs, deployments, and replica sets too.