Skip to content

Conversation

@louiszawadzki
Copy link
Contributor

@louiszawadzki louiszawadzki commented May 10, 2023

What does this PR do?

Adds an uploadFrequency parameter to change the upload frequency of batches of data.

Additional Notes

Demo:

iOS

Rare (50 secs between uploads):

image

Frequent (5 secs between uploads):

image

Android (clicking on a button every second to give an idea of time between uploads)

Rare:

image

Frequent:

image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki force-pushed the louiszawadzki/upload-frequency-setting-in-config branch from c7be705 to 2f4fcab Compare May 10, 2023 08:51
@louiszawadzki louiszawadzki force-pushed the louiszawadzki/upload-frequency-setting-in-config branch from 2f4fcab to 575506c Compare May 10, 2023 08:58
@louiszawadzki louiszawadzki marked this pull request as ready for review May 10, 2023 09:21
@louiszawadzki louiszawadzki requested a review from a team as a code owner May 10, 2023 09:21
Co-authored-by: Nikita Ogorodnikov <4046447+0xnm@users.noreply.github.com>
@louiszawadzki louiszawadzki merged commit eda3a78 into develop May 12, 2023
@louiszawadzki louiszawadzki deleted the louiszawadzki/upload-frequency-setting-in-config branch May 12, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants