From f682d03e58652af6f31e4b50f135dfc511f3e83e Mon Sep 17 00:00:00 2001 From: Zach Montoya Date: Wed, 2 Oct 2024 17:05:52 -0700 Subject: [PATCH] feat!: Implement consistency for DD_TRACE_RATE_LIMIT - Change the default value of DD_TRACE_RATE_LIMIT to 100 Issues: APMAPI-511 --- src/datadog/trace_sampler_config.cpp | 2 +- test/test_tracer_config.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/datadog/trace_sampler_config.cpp b/src/datadog/trace_sampler_config.cpp index 9216a0e6..1d595e71 100644 --- a/src/datadog/trace_sampler_config.cpp +++ b/src/datadog/trace_sampler_config.cpp @@ -224,7 +224,7 @@ Expected finalize_config( } const auto [origin, max_per_second] = - pick(env_config->max_per_second, config.max_per_second, 200); + pick(env_config->max_per_second, config.max_per_second, 100); result.metadata[ConfigName::TRACE_SAMPLING_LIMIT] = ConfigMetadata( ConfigName::TRACE_SAMPLING_LIMIT, std::to_string(max_per_second), origin); diff --git a/test/test_tracer_config.cpp b/test/test_tracer_config.cpp index 1050e216..0d2e7cc7 100644 --- a/test/test_tracer_config.cpp +++ b/test/test_tracer_config.cpp @@ -707,10 +707,10 @@ TEST_CASE("TracerConfig::trace_sampler") { } SECTION("max_per_second") { - SECTION("defaults to 200") { + SECTION("defaults to 100") { auto finalized = finalize_config(config); REQUIRE(finalized); - REQUIRE(finalized->trace_sampler.max_per_second == 200); + REQUIRE(finalized->trace_sampler.max_per_second == 100); } SECTION("must be >0 and a finite number") {