deps(nlohmann-json): FetchContent rely on find_package
#231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `FIND_PACKAGE_ARGS` will help `FetchContent_*` to satisfy the dependency with `find_package()`. If that dependency is not found, then it is built from source. Co-authored-by: Damien Mehala <damien.mehala@datadoghq.com>
dmehala
changed the title
FetchContent rely on find_package
dmehala
deleted the
dmehala/do-not-fetch-content-nlohmann-json-if-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
FIND_PACKAGE_ARGSwill helpFetchContent_*to satisfy the dependency withfind_package(). If that dependency is not found, then it is built from source.Supersede: #227
Close #227
Additional Notes
Bump version of nlohmann_json to 3.12.0.