From 5607861139c785aeb3e22fa7091206eaad762364 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20Geisend=C3=B6rfer?= Date: Tue, 20 Feb 2024 09:08:18 +0100 Subject: [PATCH] partial backport: ddtrace/tracer: removed appsec.enabled assertion in RC test (#2562) (#2567) Co-authored-by: Diana Shevchenko <40775148+dianashevchenko@users.noreply.github.com> --- ddtrace/tracer/remote_config_test.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/ddtrace/tracer/remote_config_test.go b/ddtrace/tracer/remote_config_test.go index 0959559843..f2e309f3fa 100644 --- a/ddtrace/tracer/remote_config_test.go +++ b/ddtrace/tracer/remote_config_test.go @@ -7,7 +7,6 @@ package tracer import ( "gopkg.in/DataDog/dd-trace-go.v1/ddtrace/internal" - "gopkg.in/DataDog/dd-trace-go.v1/internal/appsec" "testing" "gopkg.in/DataDog/dd-trace-go.v1/ddtrace/ext" @@ -126,14 +125,10 @@ func TestOnRemoteConfigUpdate(t *testing.T) { t.Run("RC tracing_enabled = false is applied", func(t *testing.T) { telemetryClient := new(telemetrytest.MockClient) defer telemetry.MockGlobalClient(telemetryClient)() - t.Setenv("DD_APPSEC_ENABLED", "true") Start(WithService("my-service"), WithEnv("my-env")) defer Stop() - appsec.Start() - defer appsec.Stop() - input := remoteconfig.ProductUpdate{ "path": []byte(`{"lib_config": {"tracing_enabled": false}, "service_target": {"service": "my-service", "env": "my-env"}}`), } @@ -143,7 +138,6 @@ func TestOnRemoteConfigUpdate(t *testing.T) { applyStatus := tr.onRemoteConfigUpdate(input) require.Equal(t, state.ApplyStateAcknowledged, applyStatus["path"].State) require.Equal(t, false, tr.config.enabled.current) - require.Equal(t, true, appsec.Enabled()) headers := TextMapCarrier{ traceparentHeader: "00-12345678901234567890123456789012-1234567890123456-01", tracestateHeader: "dd=s:2;o:rum;t.usr.id:baz64~~",