From 128c9121f4a5f0bc208d74e560944ebb6e3404a6 Mon Sep 17 00:00:00 2001 From: Kyle Nusbaum Date: Wed, 29 Mar 2023 15:17:51 -0500 Subject: [PATCH] .gitlab/scripts: remove BenchmarkConcurrentTracing from CI benchmarks BenchmarkConcurrentTracing is not a reliable test and seems to mostly end up testing the contention characteristics of the system it's running on. Instead we replace it with BenchmarkTracerAddSpans, which should provide more reliable benchmarks about the cost of starting spans. --- .gitlab/scripts/config-benchmarks.sh | 2 +- CONTRIBUTING.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitlab/scripts/config-benchmarks.sh b/.gitlab/scripts/config-benchmarks.sh index 8565188639..0801c7cd23 100755 --- a/.gitlab/scripts/config-benchmarks.sh +++ b/.gitlab/scripts/config-benchmarks.sh @@ -8,4 +8,4 @@ export BASELINE_SRC="/app/baseline/" export UNCONFIDENCE_THRESHOLD=2.0 export FAIL_ON_REGRESSION_THRESHOLD=$UNCONFIDENCE_THRESHOLD -export BENCHMARK_TARGETS="BenchmarkConcurrentTracing|BenchmarkStartSpan|BenchmarkSingleSpanRetention|BenchmarkInjectW3C" +export BENCHMARK_TARGETS="BenchmarkTracerAddSpans|BenchmarkStartSpan|BenchmarkSingleSpanRetention|BenchmarkInjectW3C" diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 56571a7072..9276ab0b5c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -64,5 +64,5 @@ The maintainers of this repository assign milestones to pull requests to classif Some benchmarks will run on any new PR commits, the results will be commented into the PR on completion. #### Adding a new benchmark -To add additional benchmarks that should run for every PR go to `.gitlab/scripts/run-benchmarks.sh`. -Add the name of your benchmark to the list in `-bench "BenchmarkConcurrentTracing|BenchmarkStartSpan"` using pipe character separators. Note that your new benchmark must already exist in the `main` branch, for that reason it is best for new benchmarks to be added in their own PR and a second PR opened afterwards to add them to the PR benchmark script. \ No newline at end of file +To add additional benchmarks that should run for every PR go to `.gitlab/scripts/config-benchmarks.sh`. +Add the name of your benchmark to the list in `-bench "BenchmarkConcurrentTracing|BenchmarkStartSpan"` using pipe character separators. Note that your new benchmark must already exist in the `main` branch, for that reason it is best for new benchmarks to be added in their own PR and a second PR opened afterwards to add them to the PR benchmark script.