Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump otelhttp to v0.44.0 #2274

Merged
merged 3 commits into from
Oct 17, 2023
Merged

go.mod: bump otelhttp to v0.44.0 #2274

merged 3 commits into from
Oct 17, 2023

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

bump otelhttp to v0.44.0

Motivation

#2273

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ahmed-mez ahmed-mez requested a review from a team October 17, 2023 08:25
@ahmed-mez ahmed-mez requested a review from a team as a code owner October 17, 2023 08:25
@@ -3,6 +3,8 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2023 Datadog, Inc.

//go:build go1.20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean it runs on ONLY go 1.20? Is there an easy way to instead say "at least" 1.20?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's compiled for Go 1.20 and onward.

@pr-commenter
Copy link

pr-commenter bot commented Oct 17, 2023

Benchmarks

Benchmark execution time: 2023-10-17 09:00:42

Comparing candidate commit 7d2d794 in PR branch ahmed/bump-otelhttp with baseline commit c188333 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@ahmed-mez ahmed-mez enabled auto-merge (squash) October 17, 2023 12:51
@ahmed-mez ahmed-mez merged commit 8137237 into main Oct 17, 2023
51 of 52 checks passed
@ahmed-mez ahmed-mez deleted the ahmed/bump-otelhttp branch October 17, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants