contrib/labstack/echo: Custom tags #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeljusto
commented
Nov 9, 2023
darccio
requested changes
Nov 10, 2023
New option to allow adding custom tags when creating the span. Custom tags won't replace the default tags. This is important to attach some extra information, such as user session data (e.g. authentication type), that it's useful when generating graphs from Datadog APM traces.
Following suggestion from @darccio . #2340 (comment)
|
Thank you lads! The requested changes are applied now. |
Hellzy
approved these changes
Nov 10, 2023
darccio
approved these changes
Nov 10, 2023
Following suggestion from @darccio . #2340 (comment)
|
Hey @darccio , thank you for reviewing this. I'm not allowed to merge these changes. Are there any extra steps on my side? |
|
@rafaeljusto We'll merge them. |
|
Hi @darccio , what's the policy regarding setting new tags for the library? Does it happen once a week or something? Just trying to figure out the timeline on my side as we have a couple of things depending on this change. |
|
@rafaeljusto It happens monthly. This PR has been included in the next release train that started yesterday for v1.58.0. |
|
Thank you for clarifying it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
New option to allow adding custom tags when creating the span. Custom tags won't replace the default tags.
Motivation
This is important to attach some extra information, such as user session data (e.g. authentication type), that it's useful when generating graphs from Datadog APM traces.
Reviewer's Checklist
If this interacts with the agent in a new way, a system test has been added.For Datadog employees:
@DataDog/security-design-and-guidance.