Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable gci #2344

Merged
merged 2 commits into from Nov 13, 2023
Merged

Conversation

felixge
Copy link
Member

@felixge felixge commented Nov 13, 2023

What does this PR do?

ci: disable gci

Motivation

See PROF-8609 for more info.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

See PROF-8609 for more info.
@felixge felixge requested a review from a team November 13, 2023 03:35
@felixge felixge requested review from a team as code owners November 13, 2023 03:35
@felixge felixge enabled auto-merge (squash) November 13, 2023 03:40
@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2023

Benchmarks

Benchmark execution time: 2023-11-13 03:50:44

Comparing candidate commit 11a6879 in PR branch felix.geisendoerfer/PROF-8609-disable-reviewdog with baseline commit 75d8b06 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Julio-Guerra
Copy link
Contributor

I was suggesting on slack to either:

  1. Relax the coding style defined in our wiki if we don't enforce it with CI
  2. Or update de CI to auto-apply the import fixes rather than printing a warning

I'd favor 2 for the sake of aligning with the datadog-agent coding style.

@felixge
Copy link
Member Author

felixge commented Nov 13, 2023

I was suggesting on slack to either:

  1. Relax the coding style defined in our wiki if we don't enforce it with CI
  2. Or update de CI to auto-apply the import fixes rather than printing a warning

I'd favor 2 for the sake of aligning with the datadog-agent coding style.

I'm open to doing either of these things, but I'm merging this PR for now and then we can do whatever we decide next as a separate PR. Hope it's okay? (If not we can rollback)

@felixge felixge merged commit c94b8bb into main Nov 13, 2023
51 checks passed
@felixge felixge deleted the felix.geisendoerfer/PROF-8609-disable-reviewdog branch November 13, 2023 16:59
@darccio darccio restored the felix.geisendoerfer/PROF-8609-disable-reviewdog branch November 16, 2023 10:17
@darccio darccio deleted the felix.geisendoerfer/PROF-8609-disable-reviewdog branch November 16, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants