New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: disable gci #2344
ci: disable gci #2344
Conversation
See PROF-8609 for more info.
BenchmarksBenchmark execution time: 2023-11-13 03:50:44 Comparing candidate commit 11a6879 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I was suggesting on slack to either:
I'd favor 2 for the sake of aligning with the datadog-agent coding style. |
I'm open to doing either of these things, but I'm merging this PR for now and then we can do whatever we decide next as a separate PR. Hope it's okay? (If not we can rollback) |

What does this PR do?
ci: disable gci
Motivation
See PROF-8609 for more info.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!