ddtrace/tracer: Switch default context propagation order #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JianyiGao
force-pushed
the
jennie.gao/switch-context-propagation
branch
from
fd0d4ce
to
2cae4b9
Compare
JianyiGao
force-pushed
the
jennie.gao/switch-context-propagation
branch
from
940221d
to
3b07dd2
Compare
5 tasks
darccio
reviewed
Nov 17, 2023
Comment on lines
248
to
268
|
|
||
| - name: Testing outlier gRPC v1.2 | ||
| if: inputs.ref != 'refs/heads/v2-dev' | ||
| run: | | ||
| # This hacky approach is necessary because running the tests regularly | ||
| # do not allow using grpc-go@v1.2.0 alongside sketches-go@v1.0.0 | ||
| go mod vendor | ||
|
|
||
| # Checkout grpc-go@v1.2.0 | ||
| cd vendor/google.golang.org && rm -rf grpc | ||
| git clone https://github.com/grpc/grpc-go grpc && cd grpc | ||
| git fetch origin && git checkout v1.2.0 && cd ../.. | ||
|
|
||
| # Checkout sketches-go@v1.0.0 | ||
| cd vendor/github.com/DataDog && rm -rf sketches-go | ||
| git clone https://github.com/DataDog/sketches-go && cd sketches-go | ||
| git fetch origin && git checkout v1.0.0 && cd ../.. | ||
|
|
||
| go test -mod=vendor -v ./contrib/google.golang.org/grpc.v12/... | ||
|
|
There was a problem hiding this comment.
Context: unrelated change due to the modifications for v2 CI nightly runs.
dianashevchenko
added a commit
that referenced
this pull request
Nov 17, 2023
…)" This reverts commit 4b5eb5e.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR switch default context propagation order from
tracecontext,datadogto datadog,tracecontextSystem test change: DataDog/system-tests#1853
Motivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!