New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib: add go.mod to isolate contribs gqlgen, httptreemux, go-elasticsearch, cloud.google.com/go/pubsub.v1, hashicorp/consul & hashicorp/vault #2358
Conversation
…sql, httptreemux & go-elasticsearch
bb1a5da
to
7e4d418
Compare
81985fa
to
afffd7c
Compare
BenchmarksBenchmark execution time: 2023-11-22 12:03:50 Comparing candidate commit 6848485 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
|
Makes me wonder if this should also add a |
Good proposal. I'll review it. |
|
@RomainMuller It seems that the current opinion about |
|
As agreed, I'll merge this PR and next ones without CR as long as CI shows that the contribs' tests are running properly. |


What does this PR do?
Isolates the following contribs as independent modules:
99designs/gqlgendimfeld/httptreemux.v5elastic/go-elasticsearch.v6cloud.google.com/go/pubsub.v1hashicorp/consulhashicorp/vaultThis will be done for each contrib, and this is a first PR to validate the approach. Next PRs will consist of multiple contribs.
Motivation
Security scanners yield false positives, informing vulnerable versions that are present in the go.mod but not compiled into the final binary.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!