Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: improve nightly v2 CI workflows #2360

Merged
merged 11 commits into from Nov 15, 2023

Conversation

darccio
Copy link
Contributor

@darccio darccio commented Nov 15, 2023

What does this PR do?

Builds upon #2348 & #2359 to ensure nightly CI is run on v2-dev. Fixes for smoke and system tests on v2 will be done in a separate PR.

Motivation

We need to catch any possible issue early, as we aim to dogfood dd-trace-go/v2 in around a month.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2023

Benchmarks

Benchmark execution time: 2023-11-15 16:15:57

Comparing candidate commit 8da343f in PR branch dario.castane/AIT-8917/final-v2-nightly-version with baseline commit 101c4d5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@darccio darccio changed the title .github/workflows: successfully run v2 CI workflows nightly .github/workflows: improve nightly v2 CI workflows Nov 15, 2023
@darccio darccio marked this pull request as ready for review November 15, 2023 16:42
@darccio darccio requested a review from a team as a code owner November 15, 2023 16:42
@darccio darccio merged commit bd47d89 into main Nov 15, 2023
51 checks passed
@darccio darccio deleted the dario.castane/AIT-8917/final-v2-nightly-version branch November 15, 2023 16:52
@darccio darccio restored the dario.castane/AIT-8917/final-v2-nightly-version branch November 16, 2023 10:31
@darccio darccio deleted the dario.castane/AIT-8917/final-v2-nightly-version branch November 16, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants