.github/workflows: integrate v2 CI nightly to run from main #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darccio
force-pushed
the
dario.castane/AIT-8917/v2-ci-nightlies
branch
from
91d6494
to
0585d81
Compare
BenchmarksBenchmark execution time: 2023-11-17 14:37:03 Comparing candidate commit 73ea10d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
darccio
commented
Nov 17, 2023
Comment on lines
-110
to
-117
| - name: Patch dd-trace-go version | ||
| if: ${{ inputs.branch_ref == 'refs/heads/v2-dev' }} | ||
| run: | | ||
| cd utils/build/docker/golang/app | ||
| find -type f -name '*.go' -exec sed -i 's#gopkg.in/DataDog/dd-trace-go.v1#github.com/DataDog/dd-trace-go/v2#g' {} \; | ||
| echo "replace github.com/DataDog/dd-trace-go/v2 => /home/runner/work/dd-trace-go/dd-trace-go/binaries/dd-trace-go" >> go.mod | ||
| go mod tidy | ||
|
|
There was a problem hiding this comment.
No longer required because we check out the right branch from system-tests already adapted to v2.
darccio
commented
Nov 17, 2023
Comment on lines
+17
to
+18
| env: | ||
| V2_BRANCH: ${{ inputs.ref == 'refs/heads/v2-dev' }} |
There was a problem hiding this comment.
The V2_BRANCH allows to customize the execution from main, but also set it to true in v2-dev once this PR is merged into main. This additional modification will make sure all the derived branches from v2-dev run the right CI tests.
ahmed-mez
approved these changes
Nov 17, 2023
eliottness
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Completes the implementation of nightly CI runs for v2. Builds upon #2348 #2359 #2360.
Motivation
We want to catch any regression during v2 development. Running this nightly will allow to detect them easily.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!