Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: Switch default context propagation order #2368

Merged
merged 8 commits into from Feb 6, 2024

Conversation

JianyiGao
Copy link
Contributor

@JianyiGao JianyiGao commented Nov 17, 2023

What does this PR do?

This PR switch default context propagation order from tracecontext,datadog to datadog,tracecontext
The same change is merged into v2-dev branch, this PR is to cherry pick the same commit to main so system test can run with the new default context propagation order.
System test change: DataDog/system-tests#1853

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@JianyiGao JianyiGao requested a review from a team November 17, 2023 19:14
@pr-commenter
Copy link

pr-commenter bot commented Nov 17, 2023

Benchmarks

Benchmark execution time: 2024-02-05 22:03:25

Comparing candidate commit d8d48d4 in PR branch jennie.gao/cherrypick-3b07dd2 with baseline commit 42593ee in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@darccio
Copy link
Contributor

darccio commented Nov 20, 2023

@JianyiGao Just curious: why is this change going to be merged into main? It's a breaking change.

@JianyiGao
Copy link
Contributor Author

@dianashevchenko suggested to add this change to main, we can also test the new default behavior on system tests. I am not aware that this is a breaking change, would you like to chime in Diana?

@felixge
Copy link
Member

felixge commented Nov 23, 2023

@JianyiGao Just curious: why is this change going to be merged into main? It's a breaking change.

AFAIK this is not a breaking change. See PROF-8549 for my notes on this or let's discuss in slack.

Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stuck for more than 1 month label Dec 14, 2023
@github-actions github-actions bot removed the stale Stuck for more than 1 month label Jan 5, 2024
Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stuck for more than 1 month label Jan 25, 2024
@darccio darccio removed the stale Stuck for more than 1 month label Jan 25, 2024
@mabdinur mabdinur self-assigned this Feb 5, 2024
@JianyiGao JianyiGao requested a review from a team as a code owner February 5, 2024 15:51
@JianyiGao JianyiGao requested a review from a team as a code owner February 5, 2024 17:54
@mabdinur mabdinur force-pushed the jennie.gao/cherrypick-3b07dd2 branch from 42d8571 to 288c76d Compare February 5, 2024 18:38
@mabdinur
Copy link
Contributor

mabdinur commented Feb 5, 2024

Parametric tests pass with the following commit: 288c76d

@mabdinur
Copy link
Contributor

mabdinur commented Feb 5, 2024

@katiehockman when you get a chance can you merge this PR 🥳

@dianashevchenko dianashevchenko enabled auto-merge (squash) February 6, 2024 11:58
@dianashevchenko dianashevchenko merged commit 69a4402 into main Feb 6, 2024
153 of 154 checks passed
@dianashevchenko dianashevchenko deleted the jennie.gao/cherrypick-3b07dd2 branch February 6, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants