New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/tracer: Switch default context propagation order #2368
Conversation
BenchmarksBenchmark execution time: 2024-02-05 22:03:25 Comparing candidate commit d8d48d4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
|
@JianyiGao Just curious: why is this change going to be merged into main? It's a breaking change. |
|
@dianashevchenko suggested to add this change to main, we can also test the new default behavior on system tests. I am not aware that this is a breaking change, would you like to chime in Diana? |
AFAIK this is not a breaking change. See PROF-8549 for my notes on this or let's discuss in slack. |
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
42d8571
to
288c76d
Compare
|
Parametric tests pass with the following commit: 288c76d |
|
@katiehockman when you get a chance can you merge this PR 🥳 |
What does this PR do?
This PR switch default context propagation order from tracecontext,datadog to datadog,tracecontext
The same change is merged into
v2-devbranch, this PR is to cherry pick the same commit tomainso system test can run with the new default context propagation order.System test change: DataDog/system-tests#1853
Motivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!