New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data streams] Track high watermark offsets #2511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
contrib/* related feature requests or bugs
label
Jan 16, 2024
BenchmarksBenchmark execution time: 2024-01-25 16:23:41 Comparing candidate commit cab3120 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 38 metrics, 2 unstable metrics. scenario:BenchmarkTracerAddSpans-24
|
piochelepiotr
force-pushed
the
piotr-wolski/test-high-watermark
branch
2 times, most recently
from
January 18, 2024 21:54
19d2c22
to
5648716
Compare
piochelepiotr
force-pushed
the
piotr-wolski/test-high-watermark
branch
from
January 18, 2024 22:07
5648716
to
0538d5d
Compare
Hi, please fill out the PR description. We rely on that information during release process 🙌 |
dianashevchenko
approved these changes
Jan 22, 2024
kr-igor
approved these changes
Jan 23, 2024
darccio
pushed a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Track high watermark offsets along with produce and commit offsets.
This information can be used to determine Kafka lag of consumers.
So we can now get the Kafka lag by only instrumenting the consumer service, with no instrumentation on the producer side.
This also makes the Kafka lag more reliable, since we don't rely on stitching commit & produce offsets later on, but are doing it directly in the application.
Motivation
The main motivation is improving the accuracy and reliability of the
data_streams.kafka.lag_seconds
metric.Right now, the metric has edge cases in which it doesn't work great. For example when multiple Kafka topics have the same name.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!