Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/appsec: refresher #2537

Merged
merged 2 commits into from Feb 5, 2024
Merged

ci/appsec: refresher #2537

merged 2 commits into from Feb 5, 2024

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Feb 1, 2024

What does this PR do?

  • Add macos-14 and remove macos-11
  • Upgrade the github actions in use to avoid soon-deprecated nodejs runtimes they used.
  • Update the contribs to test with ASM

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@Julio-Guerra Julio-Guerra requested a review from a team as a code owner February 1, 2024 20:46
@Julio-Guerra Julio-Guerra changed the title ci/appsec: targets and actions refresher ci/appsec: refresher Feb 1, 2024
@Julio-Guerra Julio-Guerra requested a review from a team as a code owner February 1, 2024 20:57
@pr-commenter
Copy link

pr-commenter bot commented Feb 1, 2024

Benchmarks

Benchmark execution time: 2024-02-01 21:12:19

Comparing candidate commit 5f687e0 in PR branch julio.guerra/appsec-ci-update with baseline commit bbbbd7a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

@Julio-Guerra Julio-Guerra merged commit 7595b2d into main Feb 5, 2024
335 checks passed
@Julio-Guerra Julio-Guerra deleted the julio.guerra/appsec-ci-update branch February 5, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants