ddtrace/tracer: added UnmarshalJSON method to sampling rules #2563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
AIT-9799
This PR adds a
UnmarshalJSON
method on the SamplingRule struct. This is similar tounmarshalSamplingRules
method which was used previously to process env variables.Both methods utilise one validation function, however there's NO assertion on the rule type presence.
Motivation
Motivated by the dynamic sampling initiative, where one must be able to set sampling rules through an RC, thus requiring to unmarshal data from the request.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!