Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace: tracer: wip support for meta_struct field in span #2566

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Feb 16, 2024

What does this PR do?

This PR adds the ability to send metadata in spans via the field meta_struct.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 16, 2024
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@pr-commenter
Copy link

pr-commenter bot commented Feb 16, 2024

Benchmarks

Benchmark execution time: 2024-02-16 14:08:49

Comparing candidate commit e47a415 in PR branch eliott.bouhana/meta-struct with baseline commit c86c219 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant