contrib/google.golang.org/grpc: trace metadata/request for grpc calls - #647
Merged
Conversation
This change add tags for gRPC metadata and request parameters, along with option to ignore metadata fields Fixes DataDog#643
gbbr
reviewed
Apr 30, 2020
gbbr
left a comment
gbbr
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing the work. It looks good API-wise to me, just a few nits.
Contributor
Author
|
I applied all suggestions! |
Contributor
Author
|
I fixed the wrong testcases as well. |
gbbr
reviewed
May 4, 2020
gbbr
left a comment
gbbr
left a comment
Contributor
There was a problem hiding this comment.
This is great! Almost there! Thanks for your patience :)
knusbaum
approved these changes
May 15, 2020
knusbaum
left a comment
knusbaum
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks, @mingrammer
mingrammer
added a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
…DataDog#647) This change add tags for gRPC metadata and request parameters, along with option to ignore metadata fields Fixes DataDog#643
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tags for gRPC metadata and request parameters, along with an option to ignore metadata fields
Closes #643