Skip to content

contrib/google.golang.org/grpc: trace metadata/request for grpc calls #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 15, 2020
Merged

contrib/google.golang.org/grpc: trace metadata/request for grpc calls #647

merged 10 commits into from
May 15, 2020

Conversation

mingrammer
Copy link
Contributor

@mingrammer mingrammer commented Apr 29, 2020 •
edited
Loading

This change adds tags for gRPC metadata and request parameters, along with an option to ignore metadata fields

Closes #643

@mingrammer
contrib/google.golang.org/grpc: trace metadata/request for grpc calls
325316d 
This change add tags for gRPC metadata and request parameters, along with
option to ignore metadata fields

Fixes DataDog#643
@mingrammer
fix: wrong test env
8f3314f
@gbbr gbbr added this to the 1.25.0 milestone Apr 30, 2020
gbbr
gbbr reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the work. It looks good API-wise to me, just a few nits.

@mingrammer
Copy link
Contributor Author

I applied all suggestions!

@mingrammer mingrammer requested a review from gbbr April 30, 2020 16:06
@mingrammer
Copy link
Contributor Author

mingrammer commented May 2, 2020 •
edited
Loading

I fixed the wrong testcases as well.

gbbr
gbbr reviewed May 4, 2020
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Almost there! Thanks for your patience :)

gbbr
gbbr approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks!

knusbaum
knusbaum approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @mingrammer

@knusbaum knusbaum merged commit 0543fdc into DataDog:v1 May 15, 2020
@mingrammer mingrammer deleted the grpc-request-tags branch May 16, 2020 13:49
mingrammer added a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
@mingrammer
contrib/google.golang.org/grpc: trace metadata/request for grpc calls (…
b8968d5 
…DataDog#647)

This change add tags for gRPC metadata and request parameters, along with
option to ignore metadata fields

Fixes DataDog#643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knusbaum knusbaum knusbaum approved these changes

@gbbr gbbr gbbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

contrib/google.golang.org/grpc: trace metadata/request for grpc calls
3 participants
@mingrammer @knusbaum @gbbr