-
Notifications
You must be signed in to change notification settings - Fork 319
Make SymbolDB stand alone #10064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SymbolDB stand alone #10064
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (341.48 µs) : 276, 407
. : milestone, 341,
basic (299.058 µs) : 291, 307
. : milestone, 299,
loop (8.964 ms) : 8958, 8971
. : milestone, 8964,
section candidate
noprobe (325.378 µs) : 286, 365
. : milestone, 325,
basic (296.413 µs) : 289, 304
. : milestone, 296,
loop (8.954 ms) : 8950, 8958
. : milestone, 8954,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 12 performance improvements and 8 performance regressions! Performance is the same for 31 metrics, 14 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~9217cc8d582, baseline=1.57.0-SNAPSHOT~ea7a9c78ec
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049655
Total [baseline] (8.687 s) : 0, 8686640
Agent [candidate] (1.112 s) : 0, 1112115
Total [candidate] (8.808 s) : 0, 8808378
section iast
Agent [baseline] (1.192 s) : 0, 1192489
Total [baseline] (9.353 s) : 0, 9352825
Agent [candidate] (1.255 s) : 0, 1254570
Total [candidate] (9.555 s) : 0, 9555105
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~9217cc8d582, baseline=1.57.0-SNAPSHOT~ea7a9c78ec
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.498 ms) : 0, 1498
BytebuddyAgent [baseline] (705.286 ms) : 0, 705286
BytebuddyAgent [candidate] (712.108 ms) : 0, 712108
GlobalTracer [baseline] (248.656 ms) : 0, 248656
GlobalTracer [candidate] (251.308 ms) : 0, 251308
AppSec [baseline] (32.005 ms) : 0, 32005
AppSec [candidate] (32.239 ms) : 0, 32239
Debugger [baseline] (6.341 ms) : 0, 6341
Debugger [candidate] (67.268 ms) : 0, 67268
Remote Config [baseline] (669.81 µs) : 0, 670
Remote Config [candidate] (662.737 µs) : 0, 663
Telemetry [baseline] (16.253 ms) : 0, 16253
Telemetry [candidate] (8.277 ms) : 0, 8277
Flare Poller [baseline] (4.115 ms) : 0, 4115
Flare Poller [candidate] (3.783 ms) : 0, 3783
section iast
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.504 ms) : 0, 1504
BytebuddyAgent [baseline] (831.017 ms) : 0, 831017
BytebuddyAgent [candidate] (838.335 ms) : 0, 838335
GlobalTracer [baseline] (237.926 ms) : 0, 237926
GlobalTracer [candidate] (241.226 ms) : 0, 241226
IAST [baseline] (32.938 ms) : 0, 32938
IAST [candidate] (31.397 ms) : 0, 31397
AppSec [baseline] (28.617 ms) : 0, 28617
AppSec [candidate] (31.092 ms) : 0, 31092
Debugger [baseline] (6.028 ms) : 0, 6028
Debugger [candidate] (63.918 ms) : 0, 63918
Remote Config [baseline] (598.861 µs) : 0, 599
Remote Config [candidate] (544.542 µs) : 0, 545
Telemetry [baseline] (8.033 ms) : 0, 8033
Telemetry [candidate] (7.747 ms) : 0, 7747
Flare Poller [baseline] (10.897 ms) : 0, 10897
Flare Poller [candidate] (3.633 ms) : 0, 3633
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~9217cc8d582, baseline=1.57.0-SNAPSHOT~ea7a9c78ec
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052840
Total [baseline] (10.843 s) : 0, 10843241
Agent [candidate] (1.105 s) : 0, 1105148
Total [candidate] (10.701 s) : 0, 10700520
section appsec
Agent [baseline] (1.241 s) : 0, 1241362
Total [baseline] (10.971 s) : 0, 10971348
Agent [candidate] (1.289 s) : 0, 1288516
Total [candidate] (11.035 s) : 0, 11034579
section iast
Agent [baseline] (1.195 s) : 0, 1195068
Total [baseline] (11.204 s) : 0, 11203583
Agent [candidate] (1.252 s) : 0, 1252365
Total [candidate] (11.212 s) : 0, 11211616
section profiling
Agent [baseline] (1.198 s) : 0, 1197877
Total [baseline] (10.896 s) : 0, 10896226
Agent [candidate] (1.252 s) : 0, 1251672
Total [candidate] (11.118 s) : 0, 11117612
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~9217cc8d582, baseline=1.57.0-SNAPSHOT~ea7a9c78ec
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (707.518 ms) : 0, 707518
BytebuddyAgent [candidate] (706.872 ms) : 0, 706872
GlobalTracer [baseline] (249.45 ms) : 0, 249450
GlobalTracer [candidate] (249.798 ms) : 0, 249798
AppSec [baseline] (32.223 ms) : 0, 32223
AppSec [candidate] (32.024 ms) : 0, 32024
Debugger [baseline] (6.38 ms) : 0, 6380
Debugger [candidate] (67.54 ms) : 0, 67540
Remote Config [baseline] (678.043 µs) : 0, 678
Remote Config [candidate] (637.837 µs) : 0, 638
Telemetry [baseline] (16.102 ms) : 0, 16102
Telemetry [candidate] (8.278 ms) : 0, 8278
Flare Poller [baseline] (4.173 ms) : 0, 4173
Flare Poller [candidate] (3.776 ms) : 0, 3776
section appsec
crashtracking [baseline] (1.506 ms) : 0, 1506
crashtracking [candidate] (1.497 ms) : 0, 1497
BytebuddyAgent [baseline] (738.911 ms) : 0, 738911
BytebuddyAgent [candidate] (731.54 ms) : 0, 731540
GlobalTracer [baseline] (244.342 ms) : 0, 244342
GlobalTracer [candidate] (241.429 ms) : 0, 241429
AppSec [baseline] (176.537 ms) : 0, 176537
AppSec [candidate] (175.423 ms) : 0, 175423
Debugger [baseline] (6.385 ms) : 0, 6385
Debugger [candidate] (65.515 ms) : 0, 65515
Remote Config [baseline] (703.384 µs) : 0, 703
Remote Config [candidate] (784.388 µs) : 0, 784
Telemetry [baseline] (8.27 ms) : 0, 8270
Telemetry [candidate] (8.67 ms) : 0, 8670
Flare Poller [baseline] (4.085 ms) : 0, 4085
Flare Poller [candidate] (3.637 ms) : 0, 3637
IAST [baseline] (25.321 ms) : 0, 25321
IAST [candidate] (24.93 ms) : 0, 24930
section iast
crashtracking [baseline] (1.498 ms) : 0, 1498
crashtracking [candidate] (1.53 ms) : 0, 1530
BytebuddyAgent [baseline] (832.998 ms) : 0, 832998
BytebuddyAgent [candidate] (838.775 ms) : 0, 838775
GlobalTracer [baseline] (238.769 ms) : 0, 238769
GlobalTracer [candidate] (239.691 ms) : 0, 239691
AppSec [baseline] (28.861 ms) : 0, 28861
AppSec [candidate] (28.128 ms) : 0, 28128
Debugger [baseline] (6.081 ms) : 0, 6081
Debugger [candidate] (63.874 ms) : 0, 63874
Remote Config [baseline] (608.976 µs) : 0, 609
Remote Config [candidate] (522.19 µs) : 0, 522
Telemetry [baseline] (7.957 ms) : 0, 7957
Telemetry [candidate] (7.664 ms) : 0, 7664
Flare Poller [baseline] (10.758 ms) : 0, 10758
Flare Poller [candidate] (3.546 ms) : 0, 3546
IAST [baseline] (32.573 ms) : 0, 32573
IAST [candidate] (33.661 ms) : 0, 33661
section profiling
ProfilingAgent [baseline] (111.975 ms) : 0, 111975
ProfilingAgent [candidate] (95.88 ms) : 0, 95880
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (732.708 ms) : 0, 732708
BytebuddyAgent [candidate] (744.529 ms) : 0, 744529
GlobalTracer [baseline] (222.372 ms) : 0, 222372
GlobalTracer [candidate] (225.54 ms) : 0, 225540
AppSec [baseline] (32.089 ms) : 0, 32089
AppSec [candidate] (32.672 ms) : 0, 32672
Debugger [baseline] (6.85 ms) : 0, 6850
Debugger [candidate] (67.555 ms) : 0, 67555
Remote Config [baseline] (682.388 µs) : 0, 682
Remote Config [candidate] (630.034 µs) : 0, 630
Telemetry [baseline] (16.316 ms) : 0, 16316
Telemetry [candidate] (7.984 ms) : 0, 7984
Flare Poller [baseline] (4.234 ms) : 0, 4234
Flare Poller [candidate] (4.914 ms) : 0, 4914
Profiling [baseline] (112.599 ms) : 0, 112599
Profiling [candidate] (97.076 ms) : 0, 97076
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~9217cc8d582, baseline=1.57.0-SNAPSHOT~ea7a9c78ec
dateFormat X
axisFormat %s
section baseline
no_agent (19.123 ms) : 18935, 19312
. : milestone, 19123,
appsec (18.448 ms) : 18264, 18632
. : milestone, 18448,
code_origins (17.549 ms) : 17376, 17721
. : milestone, 17549,
iast (17.72 ms) : 17541, 17899
. : milestone, 17720,
profiling (18.633 ms) : 18445, 18822
. : milestone, 18633,
tracing (17.598 ms) : 17426, 17769
. : milestone, 17598,
section candidate
no_agent (18.103 ms) : 17914, 18292
. : milestone, 18103,
appsec (18.649 ms) : 18459, 18839
. : milestone, 18649,
code_origins (17.528 ms) : 17351, 17705
. : milestone, 17528,
iast (17.562 ms) : 17386, 17738
. : milestone, 17562,
profiling (18.865 ms) : 18677, 19053
. : milestone, 18865,
tracing (17.55 ms) : 17377, 17723
. : milestone, 17550,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~9217cc8d582, baseline=1.57.0-SNAPSHOT~ea7a9c78ec
dateFormat X
axisFormat %s
section baseline
no_agent (1.212 ms) : 1200, 1224
. : milestone, 1212,
iast (3.118 ms) : 3076, 3160
. : milestone, 3118,
iast_FULL (5.712 ms) : 5655, 5769
. : milestone, 5712,
iast_GLOBAL (3.546 ms) : 3494, 3598
. : milestone, 3546,
profiling (2.015 ms) : 1998, 2032
. : milestone, 2015,
tracing (1.817 ms) : 1803, 1832
. : milestone, 1817,
section candidate
no_agent (1.208 ms) : 1196, 1220
. : milestone, 1208,
iast (3.263 ms) : 3218, 3308
. : milestone, 3263,
iast_FULL (5.941 ms) : 5881, 6001
. : milestone, 5941,
iast_GLOBAL (3.633 ms) : 3580, 3686
. : milestone, 3633,
profiling (2.579 ms) : 2553, 2604
. : milestone, 2579,
tracing (1.842 ms) : 1827, 1856
. : milestone, 1842,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~9217cc8d582, baseline=1.57.0-SNAPSHOT~ea7a9c78ec
dateFormat X
axisFormat %s
section baseline
no_agent (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
appsec (15.084 s) : 15084000, 15084000
. : milestone, 15084000,
iast (18.117 s) : 18117000, 18117000
. : milestone, 18117000,
iast_GLOBAL (18.112 s) : 18112000, 18112000
. : milestone, 18112000,
profiling (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
tracing (14.786 s) : 14786000, 14786000
. : milestone, 14786000,
section candidate
no_agent (15.518 s) : 15518000, 15518000
. : milestone, 15518000,
appsec (14.873 s) : 14873000, 14873000
. : milestone, 14873000,
iast (18.567 s) : 18567000, 18567000
. : milestone, 18567000,
iast_GLOBAL (18.004 s) : 18004000, 18004000
. : milestone, 18004000,
profiling (15.457 s) : 15457000, 15457000
. : milestone, 15457000,
tracing (14.873 s) : 14873000, 14873000
. : milestone, 14873000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~9217cc8d582, baseline=1.57.0-SNAPSHOT~ea7a9c78ec
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.484 ms) : 2432, 2536
. : milestone, 2484,
iast (2.232 ms) : 2167, 2297
. : milestone, 2232,
iast_GLOBAL (2.272 ms) : 2207, 2337
. : milestone, 2272,
profiling (2.088 ms) : 2036, 2141
. : milestone, 2088,
tracing (2.062 ms) : 2011, 2113
. : milestone, 2062,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.716 ms) : 3497, 3934
. : milestone, 3716,
iast (2.234 ms) : 2170, 2299
. : milestone, 2234,
iast_GLOBAL (2.273 ms) : 2208, 2338
. : milestone, 2273,
profiling (2.083 ms) : 2030, 2135
. : milestone, 2083,
tracing (2.067 ms) : 2016, 2118
. : milestone, 2067,
|
To be able to subscribe to symbol DB without enabling DI. Starting Symbol DB is still control from the backend.
81049d6 to
5cc036d
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
| private static void subscribeLiveDebugging( | ||
| Config config, ConfigurationUpdater configurationUpdater) { | ||
| LOGGER.debug("Subscribing to Live Debugging..."); | ||
| configurationPoller.addListener( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed here with the other listener added down below?
What Does This Do
To be able to subscribe to symbol DB without enabling DI. Starting
Symbol DB is still control from the backend.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4794