Skip to content

Mute telemetry when Connection.getClientInfo fails#11412

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/jdbc
May 19, 2026
Merged

Mute telemetry when Connection.getClientInfo fails#11412
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
andrea.marziali/jdbc

Conversation

@amarziali
Copy link
Copy Markdown
Contributor

What Does This Do

Mute the telemetry for this kind of errors:

Error : Could not get client info from DB
java.lang.AbstractMethodError
  
at ...
  at jdbc.JDBCDecorator.parseDBInfoFromConnection(JDBCDecorator.java:223)
  at jdbc.JDBCDecorator.parseDBInfo(JDBCDecorator.java:194)

Those are unactionable and the current code already handle a fallback case for that

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@amarziali amarziali added the type: enhancement Enhancements and improvements label May 19, 2026
@amarziali amarziali requested a review from a team as a code owner May 19, 2026 08:18
@amarziali amarziali added the inst: jdbc JDBC instrumentation label May 19, 2026
@amarziali amarziali requested review from ygree and removed request for a team May 19, 2026 08:18
@amarziali
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 19, 2026

View all feedbacks in Devflow UI.

2026-05-19 18:31:05 UTC ℹ️ Start processing command /merge


2026-05-19 18:31:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-05-19 19:42:17 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit a184215 into master May 19, 2026
570 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/jdbc branch May 19, 2026 19:42
@github-actions github-actions Bot added this to the 1.63.0 milestone May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: jdbc JDBC instrumentation type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants