From 8e111e49ad9aac626a634434c9ecda6e42fecae0 Mon Sep 17 00:00:00 2001 From: Brian Devins-Suresh Date: Wed, 15 Apr 2020 09:57:55 -0400 Subject: [PATCH] Revert feature to calculate sample rate based on failed reporting --- .../common/writer/ddagent/TraceProcessingDisruptor.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/dd-trace-ot/src/main/java/datadog/trace/common/writer/ddagent/TraceProcessingDisruptor.java b/dd-trace-ot/src/main/java/datadog/trace/common/writer/ddagent/TraceProcessingDisruptor.java index 16a5889c8ff..7c79b9f10ba 100644 --- a/dd-trace-ot/src/main/java/datadog/trace/common/writer/ddagent/TraceProcessingDisruptor.java +++ b/dd-trace-ot/src/main/java/datadog/trace/common/writer/ddagent/TraceProcessingDisruptor.java @@ -3,7 +3,6 @@ import com.lmax.disruptor.EventHandler; import datadog.common.exec.DaemonThreadFactory; import datadog.opentracing.DDSpan; -import datadog.opentracing.DDSpanContext; import datadog.trace.common.processor.TraceProcessor; import datadog.trace.common.writer.DDAgentWriter; import java.util.List; @@ -64,12 +63,7 @@ public void onEvent( final DisruptorEvent> event, final long sequence, final boolean endOfBatch) { try { if (event.data != null) { - if (1 < event.representativeCount && !event.data.isEmpty()) { - // attempt to have agent scale the metrics properly - ((DDSpan) event.data.get(0).getLocalRootSpan()) - .context() - .setMetric(DDSpanContext.SAMPLE_RATE_KEY, 1d / event.representativeCount); - } + // TODO populate `_sample_rate` metric in a way that accounts for lost/dropped traces try { event.data = processor.onTraceComplete(event.data); final byte[] serializedTrace = api.serializeTrace(event.data);