From ae32e1dee4b183ab71cd10c3bca65ac9cad7a8a8 Mon Sep 17 00:00:00 2001
From: Richard Startin <richard.startin@datadoghq.com>
Date: Fri, 1 May 2020 10:46:04 +0100
Subject: [PATCH] replace collection.size() > 0 with not collection.isEmpty()

---
 .../src/main/java/datadog/trace/agent/tooling/Instrumenter.java | 2 +-
 .../trace/agent/tooling/muzzle/MuzzleVersionScanPlugin.java     | 2 +-
 .../trace/instrumentation/hibernate/HibernateDecorator.java     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/Instrumenter.java b/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/Instrumenter.java
index 8e01b6af9ba..a5da95566a6 100644
--- a/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/Instrumenter.java
+++ b/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/Instrumenter.java
@@ -67,7 +67,7 @@ public Default(final String instrumentationName, final String... additionalNames
       instrumentationPrimaryName = instrumentationName;
 
       enabled = Config.get().isIntegrationEnabled(instrumentationNames, defaultEnabled());
-      if (contextStore().size() > 0) {
+      if (!contextStore().isEmpty()) {
         contextProvider = new FieldBackedProvider(this);
       } else {
         contextProvider = NoopContextProvider.INSTANCE;
diff --git a/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/MuzzleVersionScanPlugin.java b/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/MuzzleVersionScanPlugin.java
index 4f47ab5f981..fda897d8bd5 100644
--- a/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/MuzzleVersionScanPlugin.java
+++ b/dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/muzzle/MuzzleVersionScanPlugin.java
@@ -166,7 +166,7 @@ private static String prettyPrint(final String prefix, final Reference ref) {
     if (ref.getSuperName() != null) {
       builder.append(" extends<").append(ref.getSuperName()).append(">");
     }
-    if (ref.getInterfaces().size() > 0) {
+    if (!ref.getInterfaces().isEmpty()) {
       builder.append(" implements ");
       for (final String iface : ref.getInterfaces()) {
         builder.append(" <").append(iface).append(">");
diff --git a/dd-java-agent/instrumentation/hibernate/src/main/java/datadog/trace/instrumentation/hibernate/HibernateDecorator.java b/dd-java-agent/instrumentation/hibernate/src/main/java/datadog/trace/instrumentation/hibernate/HibernateDecorator.java
index 6bc8b953723..198e89898c6 100644
--- a/dd-java-agent/instrumentation/hibernate/src/main/java/datadog/trace/instrumentation/hibernate/HibernateDecorator.java
+++ b/dd-java-agent/instrumentation/hibernate/src/main/java/datadog/trace/instrumentation/hibernate/HibernateDecorator.java
@@ -62,7 +62,7 @@ public String entityName(final Object entity) {
     } else if (annotations.contains("javax.persistence.Entity")) {
       // We were given an instance of an entity.
       name = entity.getClass().getName();
-    } else if (entity instanceof List && ((List) entity).size() > 0) {
+    } else if (entity instanceof List && !((List) entity).isEmpty()) {
       // We have a list of entities.
       name = entityName(((List) entity).get(0));
     }