Support using the Java tracer with both -javaagent and -jar at the same time #4924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
force-pushed
the
mcculls/support-tracer-as-javaagent-and-jar-at-same-time
branch
from
d083335
to
6e53f1c
Compare
…me time (start JMX at same time to exercise runtime metrics)
mcculls
force-pushed
the
mcculls/support-tracer-as-javaagent-and-jar-at-same-time
branch
from
6e53f1c
to
d1c68f7
Compare
am312
approved these changes
Mar 20, 2023
mcculls
deleted the
mcculls/support-tracer-as-javaagent-and-jar-at-same-time
branch
mcculls
added
comp: core
ValentinZakharov
pushed a commit
that referenced
this pull request
Mar 28, 2023
…me time (start JMX at same time to exercise runtime metrics) (#4924)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Cleans up how we load classes via the CLI to avoid checking the code source location unless we really need it.
For example, if the agent classloader is already installed then we don't need the tracer's code source location.
Motivation
This avoids a potential exception when
dd-java-agentis used with both-javaagentand-jarat the same time.(The original exception occurred because the code source location of
AgentJarbecamenullafter we addeddd-java-agentto the boot-class-path - determining that we're runningdd-java-agentwith-jarfrompremainturns out to be non-trivial, it was easier to adjust the code sodd-java-agentcan work in both places.)