New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always log inject service, version, and env #2696
Conversation
Overall package sizeSelf size: 3.54 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #2696 +/- ##
==========================================
- Coverage 89.65% 89.64% -0.01%
==========================================
Files 302 302
Lines 10505 10531 +26
Branches 33 33
==========================================
+ Hits 9418 9441 +23
- Misses 1087 1090 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenchmarksComparing candidate commit 453d6c3 in PR branch Found 3 performance improvements and 1 performance regressions! Performance is the same for 962 cases. scenario:plugin-http-server-with-tracer-14
scenario:plugin-graphql-with-depth-off-16
scenario:plugin-http-server-control-18
|
0df4f09
to
453d6c3
Compare
I always found it counterintuitive that logs outside of spans were missing this data. |
Thanks for the quick turnaround! 🥳❤️ |
Fixes #2688
What does this PR do?
Makes log injection always run, even if there is no active span.
Motivation
A user may still want to correlate logs to a given service, even if there was no active span at the time. To do this, it is necessary to always include the service, version, and env data even when there is no active span.