-
Notifications
You must be signed in to change notification settings - Fork 167
Re-enable code coverage using codecov #2464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2464 +/- ##
============================================
+ Coverage 79.32% 79.73% +0.40%
- Complexity 0 216 +216
============================================
Files 125 104 -21
Lines 12713 12669 -44
============================================
+ Hits 10085 10102 +17
+ Misses 2628 2567 -61
Flags with carried forward coverage won't be shown. Click here to find out more. see 180 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
233762b to
1741c85
Compare
4c11a15 to
c5b83dd
Compare
| name: Install CodeCov Uploader Dependencies | ||
| command: | | ||
| sudo apt update | ||
| sudo apt install -y gpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: add gpg to base buster container.
Maybe just include it already in dockerfile.
| pattern: "^[^.]+$" | ||
| value: << parameters.resource_class >> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We test ... that no dot is in the resource name because they're prefixed arm.... right.
Makefile
Outdated
| else \ | ||
| echo "Running tests without coverage"; \ | ||
| echo "$(TEST_EXTRA_ENV) $(ENV_OVERRIDE) php $(TEST_EXTRA_INI) $(REQUEST_INIT_HOOK) $(PHPUNIT) $(1) --filter=$(FILTER)"; \ | ||
| $(TEST_EXTRA_ENV) $(ENV_OVERRIDE) php $(TEST_EXTRA_INI) $(REQUEST_INIT_HOOK) $(PHPUNIT) $(1) --filter=$(FILTER); \ | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spaces as indents here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good :-)
Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
b4e14c0 to
3340f39
Compare
BenchmarksBenchmark execution time: 2024-01-16 16:19:21 Comparing candidate commit 5726c5b in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 40 metrics, 49 unstable metrics. scenario:PHPRedisBench/benchRedisBaseline
|
9c32ab3 to
5726c5b
Compare
Description
This PR brings back code coverage using codecov.
CODECOV_TOKENadded to CircleCI > Project Settigns > Environment VariablesCODECOV_TOKENproject environment variable to the docker imageCIRCLE_PROJECT_USERNAMEandCIRCLE_PROJECT_REPONAME, as they are required when setting the slug (<org>/<repo>)CIandCIRCLECI, as they are required to properly detect CircleCI as the CI providerYou can see a sample report below.
One limitation of this coverage is that functions written in the extension but solely tested in PHP (I don't think of any out of my head, but hypothetically) would be considered uncovered.
Reviewer checklist