Skip to content

ci: do not persiste git credentials in GitHub Actions - #11640

Merged
brettlangdon merged 2 commits into
mainfrom
brettlangdon/fix.up.zizmor
Dec 9, 2024
Merged

ci: do not persiste git credentials in GitHub Actions#11640
brettlangdon merged 2 commits into
mainfrom
brettlangdon/fix.up.zizmor

Conversation

@brettlangdon

@brettlangdon brettlangdon commented Dec 9, 2024

Copy link
Copy Markdown
Member

Found via zizmor.

I also included one template expansion change as well.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 9, 2024
@brettlangdon
brettlangdon requested review from a team as code owners December 9, 2024 14:27
@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

.github/workflows/build-and-publish-image.yml                           @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/build_deploy.yml                                      @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/build_python_3.yml                                    @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/changelog.yml                                         @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/codeowners.yml                                        @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/codeql-analysis.yml                                   @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/django-overhead-profile.yml                           @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/encoders-profile.yml                                  @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/flask-overhead-profile.yml                            @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/generate-package-versions.yml                         @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/pr-name.yml                                           @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/requirements-locks.yml                                @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/rust-ci.yml                                           @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/set-target-milestone.yml                              @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/test_frameworks.yml                                   @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/test_lib_injection.yml                                @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/unit_tests.yml                                        @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/upstream-issues.yml                                   @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter

pr-commenter Bot commented Dec 9, 2024

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2024-12-09 15:08:17

Comparing candidate commit c5a88b9 in PR branch brettlangdon/fix.up.zizmor with baseline commit 474dfb1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 382 metrics, 2 unstable metrics.

@erikayasuda erikayasuda left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish there was a way to define this in some kind of base definition like in GitLab or CircleCI 😅

@brettlangdon

Copy link
Copy Markdown
Member Author

Wish there was a way to define this in some kind of base definition like in GitLab or CircleCI 😅

If we can address some of the other issues, we can just add a zizmor check as an action as well to prevent anyone from adding/modifying an action to remove it.

@brettlangdon
brettlangdon merged commit b875079 into main Dec 9, 2024
@brettlangdon
brettlangdon deleted the brettlangdon/fix.up.zizmor branch December 9, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants