Skip to content

Conversation

@brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Jul 14, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 14, 2025
@brettlangdon brettlangdon requested review from a team as code owners July 14, 2025 17:50
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python

@brettlangdon brettlangdon enabled auto-merge (squash) July 14, 2025 17:50
@emmettbutler emmettbutler self-requested a review July 14, 2025 18:10
@github-actions
Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 293 ± 4 ms.

The average import time from base is: 297 ± 4 ms.

The import time difference between this PR and base is: -4.8 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.252 ms (0.77%)
ddtrace.bootstrap.sitecustomize 1.550 ms (0.53%)
ddtrace.bootstrap.preload 1.550 ms (0.53%)
ddtrace.internal.remoteconfig.client 0.708 ms (0.24%)
ddtrace 0.702 ms (0.24%)
ddtrace.internal._unpatched 0.038 ms (0.01%)
json 0.038 ms (0.01%)
json.decoder 0.038 ms (0.01%)
re 0.038 ms (0.01%)
enum 0.038 ms (0.01%)
types 0.038 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jul 14, 2025

Benchmarks

Benchmark execution time: 2025-07-14 18:36:35

Comparing candidate commit 97ad1c5 in PR branch brettlangdon/update.system-tests with baseline commit e0a772c in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 546 metrics, 2 unstable metrics.

scenario:iastaspects-format_map_aspect

  • 🟥 execution_time [+458.502ns; +529.960ns] or [+14.060%; +16.252%]

scenario:iastaspectsospath-ospathsplitext_aspect

  • 🟥 execution_time [+470.451ns; +675.051ns] or [+10.349%; +14.850%]

@brettlangdon brettlangdon merged commit b4bdef9 into main Jul 14, 2025
399 of 400 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/update.system-tests branch July 14, 2025 18:39
@github-actions
Copy link
Contributor

The backport to 3.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.9 3.9
# Navigate to the new working tree
cd .worktrees/backport-3.9
# Create a new branch
git switch --create backport-13989-to-3.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4bdef9efa90dfcce2febe360f10e34573fd5479
# Push it to GitHub
git push --set-upstream origin backport-13989-to-3.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.9

Then, create a pull request where the base branch is 3.9 and the compare/head branch is backport-13989-to-3.9.

@github-actions
Copy link
Contributor

The backport to 3.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.10 3.10
# Navigate to the new working tree
cd .worktrees/backport-3.10
# Create a new branch
git switch --create backport-13989-to-3.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4bdef9efa90dfcce2febe360f10e34573fd5479
# Push it to GitHub
git push --set-upstream origin backport-13989-to-3.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.10

Then, create a pull request where the base branch is 3.10 and the compare/head branch is backport-13989-to-3.10.

brettlangdon added a commit that referenced this pull request Jul 15, 2025
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit b4bdef9)
@github-actions
Copy link
Contributor

The backport to 3.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-3.10 3.10
# Navigate to the new working tree
cd .worktrees/backport-3.10
# Create a new branch
git switch --create backport-13989-to-3.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b4bdef9efa90dfcce2febe360f10e34573fd5479
# Push it to GitHub
git push --set-upstream origin backport-13989-to-3.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-3.10

Then, create a pull request where the base branch is 3.10 and the compare/head branch is backport-13989-to-3.10.

alyshawang pushed a commit that referenced this pull request Jul 25, 2025
## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants