chore(tornado): drop support for <6.1 #15369
Conversation
|
|
mabdinur
force-pushed
the
bump-tornado
branch
from
2849fb4 to
3688394
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 260 ± 4 ms. The average import time from base is: 266 ± 4 ms. The import time difference between this PR and base is: -6.4 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate bump-tornado (025e461) with baseline main (9739b2f) 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.252ms (SLO: <22.300ms 📉 -13.7%) vs baseline: ~same Memory: ✅ 67.869MB (SLO: <70.500MB -3.7%) vs baseline: +4.5% ✅ exception-replay-enabledTime: ✅ 1.340ms (SLO: <1.450ms -7.6%) vs baseline: +0.1% Memory: ✅ 66.021MB (SLO: <67.500MB -2.2%) vs baseline: +4.8% ✅ iastTime: ✅ 19.268ms (SLO: <22.250ms 📉 -13.4%) vs baseline: -0.2% Memory: ✅ 67.771MB (SLO: <70.000MB -3.2%) vs baseline: +4.3% ✅ profilerTime: ✅ 15.584ms (SLO: <16.550ms -5.8%) vs baseline: +0.2% Memory: ✅ 55.897MB (SLO: <57.500MB -2.8%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 19.378ms (SLO: <21.750ms 📉 -10.9%) vs baseline: ~same Memory: ✅ 67.849MB (SLO: <70.500MB -3.8%) vs baseline: +4.3% ✅ span-code-originTime: ✅ 22.737ms (SLO: <28.200ms 📉 -19.4%) vs baseline: -0.3% Memory: ✅ 70.172MB (SLO: <71.000MB 🟡 -1.2%) vs baseline: +4.7% ✅ tracerTime: ✅ 19.246ms (SLO: <21.750ms 📉 -11.5%) vs baseline: -0.6% Memory: ✅ 67.889MB (SLO: <70.000MB -3.0%) vs baseline: +4.7% ✅ tracer-and-profilerTime: ✅ 21.352ms (SLO: <23.500ms -9.1%) vs baseline: -0.2% Memory: ✅ 69.029MB (SLO: <71.000MB -2.8%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.309ms (SLO: <21.500ms 📉 -10.2%) vs baseline: ~same Memory: ✅ 67.889MB (SLO: <70.000MB -3.0%) vs baseline: +4.6% ✅ tracer-minimalTime: ✅ 16.697ms (SLO: <17.500ms -4.6%) vs baseline: +0.3% Memory: ✅ 67.790MB (SLO: <70.000MB -3.2%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 19.276ms (SLO: <21.750ms 📉 -11.4%) vs baseline: +0.2% Memory: ✅ 67.849MB (SLO: <72.500MB -6.4%) vs baseline: +4.4% ✅ tracer-no-cachesTime: ✅ 17.336ms (SLO: <19.650ms 📉 -11.8%) vs baseline: ~same Memory: ✅ 67.768MB (SLO: <70.000MB -3.2%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.787ms (SLO: <20.100ms -6.5%) vs baseline: +0.5% Memory: ✅ 67.768MB (SLO: <70.000MB -3.2%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 18.953ms (SLO: <21.500ms 📉 -11.8%) vs baseline: ~same Memory: ✅ 67.790MB (SLO: <70.000MB -3.2%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 19.092ms (SLO: <22.000ms 📉 -13.2%) vs baseline: +0.2% Memory: ✅ 67.810MB (SLO: <70.500MB -3.8%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.727ms (SLO: <47.150ms 📉 -17.9%) vs baseline: +0.5% Memory: ✅ 39.059MB (SLO: <47.000MB 📉 -16.9%) vs baseline: +4.7% ✅ add-metricsTime: ✅ 256.979ms (SLO: <344.800ms 📉 -25.5%) vs baseline: -0.5% Memory: ✅ 43.333MB (SLO: <47.500MB -8.8%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 317.481ms (SLO: <321.000ms 🟡 -1.1%) vs baseline: +1.3% Memory: ✅ 43.332MB (SLO: <47.500MB -8.8%) vs baseline: +4.7% ✅ get-contextTime: ✅ 78.697ms (SLO: <92.350ms 📉 -14.8%) vs baseline: +0.1% Memory: ✅ 39.332MB (SLO: <46.500MB 📉 -15.4%) vs baseline: +4.7% ✅ is-recordingTime: ✅ 36.142ms (SLO: <44.500ms 📉 -18.8%) vs baseline: -0.4% Memory: ✅ 39.009MB (SLO: <47.500MB 📉 -17.9%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 57.161ms (SLO: <67.650ms 📉 -15.5%) vs baseline: ~same Memory: ✅ 39.484MB (SLO: <47.000MB 📉 -16.0%) vs baseline: +4.8% ✅ set-statusTime: ✅ 42.464ms (SLO: <50.400ms 📉 -15.7%) vs baseline: +0.2% Memory: ✅ 39.000MB (SLO: <47.000MB 📉 -17.0%) vs baseline: +4.8% ✅ startTime: ✅ 35.440ms (SLO: <43.450ms 📉 -18.4%) vs baseline: +0.1% Memory: ✅ 39.029MB (SLO: <47.000MB 📉 -17.0%) vs baseline: +4.9% ✅ start-finishTime: ✅ 82.178ms (SLO: <88.000ms -6.6%) vs baseline: ~same Memory: ✅ 36.608MB (SLO: <46.500MB 📉 -21.3%) vs baseline: +4.6% ✅ start-finish-telemetryTime: ✅ 83.649ms (SLO: <89.000ms -6.0%) vs baseline: +0.2% Memory: ✅ 36.628MB (SLO: <46.500MB 📉 -21.2%) vs baseline: +4.7% ✅ update-nameTime: ✅ 36.968ms (SLO: <45.150ms 📉 -18.1%) vs baseline: -0.6% Memory: ✅ 39.118MB (SLO: <47.000MB 📉 -16.8%) vs baseline: +5.2% 🟡 packagespackageforrootmodulemapping - 4/4✅ cache_offTime: ✅ 342.860ms (SLO: <354.300ms -3.2%) vs baseline: -0.7% Memory: ✅ 41.094MB (SLO: <41.500MB 🟡 -1.0%) vs baseline: +4.3% ✅ cache_onTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.8% Memory: ✅ 39.620MB (SLO: <41.000MB -3.4%) vs baseline: +4.8%
|
mabdinur
force-pushed
the
bump-tornado
branch
from
dfcdbe6 to
6253a4d
Compare
releasenotes/notes/update-tornado-support-5c87ee2d79ae54c4.yaml
Outdated
Show resolved
Hide resolved
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.0 4.0
# Navigate to the new working tree
cd .worktrees/backport-4.0
# Create a new branch
git switch --create backport-15369-to-4.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2f862fe05cf1d43641393aee80a62a82254d0de0
# Push it to GitHub
git push --set-upstream origin backport-15369-to-4.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.0Then, create a pull request where the |
Description
Drops support for Tornado versions less than 6.1. The minimum supported version is now Tornado >=6.1, which is asyncio-based. Updated tests and documentation to reflect this change.
Testing
Updated Tornado integration tests to only run against Tornado >=6.1. All existing tests pass with the new minimum version requirement.
Risks
Low. Tornado v6.1 was released in 2020 and has been stable. Users on older versions will need to upgrade to continue using the integration.
Additional Notes
_supported_versions()to reflect the new minimum version requirementriotfile.pyto remove older Tornado versions