[aiohttp] Fix race condition in testing #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd
force-pushed
the
fix-aiohttp-test-race
branch
from
4c13bb1 to
4e1783a
Compare
The current code only yield once the thread have started, though there's a little chance that one of the thread did not had time to actually sent its request yet. That means that the requests will never be served and the thread will fail. This patch fixes this by making sure to do pass the execution to the asyncio loop between each join, just in case a request needs to be handled. Fixes DataDog#876
jd
force-pushed
the
fix-aiohttp-test-race
branch
from
4e1783a to
b5ba9d1
Compare
brettlangdon
approved these changes
Apr 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code only yield once the thread have started, though there's a
little chance that one of the thread did not had time to actually sent its
request yet. That means that the requests will never be served and the thread
will fail.
This patch fixes this by making sure to do pass the execution to the asyncio
loop between each join, just in case a request needs to be handled.
Fixes #876