From 760e084bdf5267ec962f66da7a62815330a4d70c Mon Sep 17 00:00:00 2001 From: Ivo Anjo Date: Wed, 13 Mar 2024 09:16:43 +0000 Subject: [PATCH] Remove `allow_restart` argument I initially added this thinking it may make it easier for testing and/or experimentation, but after feedback from review, let's go without it for now -- we can always re-add later. --- lib/datadog/core/remote/worker.rb | 4 ++-- spec/datadog/core/remote/worker_spec.rb | 12 ------------ 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/lib/datadog/core/remote/worker.rb b/lib/datadog/core/remote/worker.rb index e8be1231f50..86868562ca7 100644 --- a/lib/datadog/core/remote/worker.rb +++ b/lib/datadog/core/remote/worker.rb @@ -19,12 +19,12 @@ def initialize(interval:, &block) @block = block end - def start(allow_restart: false) + def start Datadog.logger.debug { 'remote worker starting' } acquire_lock - if @stop_requested && !allow_restart + if @stop_requested Datadog.logger.debug('remote worker: refusing to restart after previous stop') return end diff --git a/spec/datadog/core/remote/worker_spec.rb b/spec/datadog/core/remote/worker_spec.rb index 040ebd5e586..20cf0f087cd 100644 --- a/spec/datadog/core/remote/worker_spec.rb +++ b/spec/datadog/core/remote/worker_spec.rb @@ -77,18 +77,6 @@ worker.start expect(worker.instance_variable_get(:@started)).to be false end - - context 'when calling start with allow_restart: true' do - it 'restarts the worker after being stopped once' do - worker.start - expect(worker.instance_variable_get(:@started)).to be true - - worker.stop - - worker.start(allow_restart: true) - expect(worker.instance_variable_get(:@started)).to be true - end - end end describe '#stop' do