Add "multi" methods instrumentation for Rails cache integration - #1217
Conversation
746d934 to
b546cc9
Compare
|
👋 @michaelkl thanks for the contribution! Generally this looks like a really solid addition to the library. I am a bit backlogged right now but should be able to give this a thoughtful review in the coming days, I want to review how some other libraries and languages handle Also, for the linting failed tests, |
b546cc9 to
4516f85
Compare
|
Thank you @ericmustin ! Glad to help the community! I will remove the Draft status from the PR when it turns out ready to be reviewed. Take your time, no rush at all! |
d8403dd to
84ebc85
Compare
marcotc
left a comment
There was a problem hiding this comment.
Great work @michaelkl! I left a few suggestion on my review, but it looks very close to completion. Great job on getting it to pass tests on all (even very old) versions of Rails 👍
84ebc85 to
0a08188
Compare
marcotc
left a comment
There was a problem hiding this comment.
Thank you very much, @michaelkl! 🚀
In current implementation only
read,writeandfetchmethods ofActiveSupport::Cache::Storeare instrumented. This PR adds the instrumentation ofread_multi,write_multiandfetch_multimethods.