make sure to not execute to many request for appsec integration specs #2843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
force-pushed
the
fix-appsec-integration-test-time
branch
from
20e79e0 to
e1ac34d
Compare
marcotc
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve CI time for appsec integration specs.
We have divided all specs into single specs. The way tests were organized meant that for every assertion, we were making a new request to the test app. By groping the specs into a bigger block we can improve CI time.
For future we can extract those shared examples into a separate file
Motivation
Additional Notes
How to test the change?