DI: extract instance_double_agent_settings_with_stubs to DRY tests #5087
+14
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-datadog
changed the title
|
Thank you for updating Change log entry section 👏 Visited at: 2025-11-24 18:00:59 UTC |
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 78eea14 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Strech
approved these changes
Nov 26, 2025
Co-authored-by: Sergey Fedorov <oni.strech@gmail.com>
p-datadog
pushed a commit
that referenced
this pull request
Nov 27, 2025
* master: Transports: DRY HTTP client code (#5095) DI: extract instance_double_agent_settings_with_stubs to DRY tests (#5087) [PROF-13115] Fix profiler ractor specs failing on Ruby 4 [PROF-13115] Bootstrap installing dependencies on Ruby 4.0.0-preview2 Clarify support for `rb_obj_info` and why it's OK to not have it Tweak pending to not apply to all Ruby preview versions Do not try to use `rb_obj_info` on Ruby 4.0 Adjust stack collector spec to account for changed Ruby 4 behavior [PROF-13115] Disable heap profiling on Ruby 4 preview due to incompatibility Stub sampling in integration tests Rewrite security response tests Bump the gh-actions-packages group across 3 directories with 13 updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extracts a test helper to reduce duplication in DI tests
Motivation:
Less copy/paste
Change log entry
None
Additional Notes:
How to test the change?
Change is in tests only