Skip to content

Conversation

@chanhyeokseo
Copy link
Contributor

@chanhyeokseo chanhyeokseo commented Dec 11, 2024

What does this PR do? What is the motivation?

This PR updates the permissions.md file to:

  1. Add sudo to the command requiring elevated privileges.
  2. Standardize the syntax structure of the commands for consistency with other examples (e.g., line 47).

The motivation is to improve consistency and clarity in the documentation, ensuring that users can follow the commands easily and without confusion.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

I closed the previously approved PR and reopened it to align the branch name. #26644

@chanhyeokseo chanhyeokseo requested a review from a team as a code owner December 11, 2024 06:38
@brett0000FF brett0000FF added the under_review Sent to someone outside of the docs team for review. label Dec 11, 2024
@brett0000FF
Copy link
Contributor

@mushroom1324 - Thanks for this contribution! I am going to have one of our engineers validate, and then I can get this merged for us. 🚀

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Edit: I will merge this tomorrow.

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-11 22:42:11 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-12 02:42:15 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@chanhyeokseo
Copy link
Contributor Author

Thanks for the kind review. 😄

Feel free to let me know if anything is required.

@brett0000FF brett0000FF merged commit 30f4f62 into DataDog:master Dec 12, 2024
10 of 13 checks passed
@chanhyeokseo chanhyeokseo deleted the mushroom1324/update-permissions-md branch December 13, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergequeue-status: removed under_review Sent to someone outside of the docs team for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants