Skip to content

Deprecating Oracle Python integration (DBMON-3776) #22299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhgilbert merged 11 commits into from
Mar 28, 2024
Merged

Deprecating Oracle Python integration (DBMON-3776) #22299

jhgilbert merged 11 commits into from
Mar 28, 2024

Conversation

@nenadnoveljic
Copy link
Member

@nenadnoveljic nenadnoveljic commented Mar 22, 2024

What does this PR do? What is the motivation?

The Oracle Python integration will be deprecated in the next Agent release. This document preserves the configuration steps for the older Agent releases.

Merge instructions

  • Please merge after reviewing

Additional notes

@nenadnoveljic nenadnoveljic self-assigned this Mar 22, 2024
@nenadnoveljic nenadnoveljic requested a review from a team as a code owner March 22, 2024 09:26
@github-actions github-actions bot added the Guide Content impacting a guide label Mar 22, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@nenadnoveljic nenadnoveljic changed the title Deprecating Oracle Python integration Deprecating Oracle Python integration (DBMON-3776) Mar 22, 2024
hestonhoffman
hestonhoffman reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is in progress, but I'd like to leave this open and take a look at the changes to the main integration page before I review further. That way we can cut down on duplication (and I can get a clearer idea of how we should document this :) )

@hestonhoffman hestonhoffman self-assigned this Mar 22, 2024
@hestonhoffman hestonhoffman added the editorial review Waiting on a more in-depth review label Mar 22, 2024
nenadnoveljic and others added 5 commits March 25, 2024 08:29
jhgilbert
jhgilbert reviewed Mar 26, 2024
View reviewed changes
jhgilbert
jhgilbert reviewed Mar 26, 2024
View reviewed changes
content/en/integrations/guide/deprecated-oracle-integration.md Outdated
3. Once configured, you can create a [monitor][10] based on `oracle.custom_query.locks` metrics.
## Data Collected
Copy link
Contributor

@jhgilbert jhgilbert Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Data Collected" section feels out of scope for the page, I recommend deleting it. They can read about the integration on its dedicated page.

nenadnoveljic and others added 2 commits March 27, 2024 09:45
@nenadnoveljic @jhgilbert
Update content/en/integrations/guide/_index.md
9e4ee4a 
Co-authored-by: jhgilbert <jen.gilbert@datadoghq.com>
@nenadnoveljic
deleted datra collection
899bf5f
@jhgilbert jhgilbert merged commit d6c42cb into master Mar 28, 2024
@jhgilbert jhgilbert deleted the nenadnoveljic/old-oracle-integration branch March 28, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hestonhoffman hestonhoffman hestonhoffman left review comments

@jhgilbert jhgilbert jhgilbert approved these changes

Assignees

@nenadnoveljic nenadnoveljic

@hestonhoffman hestonhoffman

Labels

database_monitoring editorial review Waiting on a more in-depth review Guide Content impacting a guide

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nenadnoveljic @jhgilbert @hestonhoffman