Skip to content

[Network Path] Recommend not setting UDP port #25193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
git-thuerk-done merged 4 commits into from
Sep 20, 2024
Merged

[Network Path] Recommend not setting UDP port #25193

git-thuerk-done merged 4 commits into from
Sep 20, 2024

Conversation

@AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Sep 11, 2024

What does this PR do? What is the motivation?

[Network Path] Recommend not setting UDP port

Merge instructions

  • Please merge after reviewing

Additional notes

@AlexandreYang AlexandreYang requested a review from a team as a code owner September 11, 2024 14:27
ken-schneider
ken-schneider reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@ken-schneider ken-schneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small suggestion, but either way this is good for me once the typo in recommend is fixed :)

AlexandreYang
AlexandreYang commented Sep 11, 2024
View reviewed changes
AlexandreYang
AlexandreYang commented Sep 11, 2024
View reviewed changes
git-thuerk-done
git-thuerk-done approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@git-thuerk-done git-thuerk-done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@AlexandreYang
Copy link
Member Author

AlexandreYang commented Sep 11, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 11, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@AlexandreYang
Copy link
Member Author

AlexandreYang commented Sep 11, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 11, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Sep 11, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@git-thuerk-done git-thuerk-done merged commit 3781bf0 into master Sep 20, 2024
@git-thuerk-done git-thuerk-done deleted the AlexandreYang-patch-1 branch September 20, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ken-schneider ken-schneider ken-schneider left review comments

@git-thuerk-done git-thuerk-done git-thuerk-done approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexandreYang @git-thuerk-done @ken-schneider