DOCS-9227: Add curly braces to SQL Server code samples #25799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neko-dd
reviewed
Oct 17, 2024
| ```yaml | ||
| connector: odbc | ||
| driver: '{ODBC Driver 18 for SQL Server}' | ||
| driver: 'ODBC Driver 18 for SQL Server' |
Contributor
There was a problem hiding this comment.
Is this a placeholder or a literal string?
Contributor
Author
There was a problem hiding this comment.
Placeholder, but you can ignore this for now. I forgot to add the "do not merge" label.
drichards-87
added
WORK IN PROGRESS
github-actions
bot
removed
the
Architecture
drichards-87
changed the title
drichards-87
removed
WORK IN PROGRESS
lu-zhengda
approved these changes
Oct 28, 2024
hestonhoffman
approved these changes
Oct 28, 2024
Contributor
Author
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
deforest/docs-9227-dbm-code-samples-curly-braces
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
theraffoul
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Remove curly braces from code sample * Add curly braces to code samples * Add curly braces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Adds curly braces to code samples. Note that the original request was to remove the curly braces, but after speaking to Engineering, they've recommended that we instead add them to all of the samples.
Merge instructions
Additional notes