Skip to content

Conversation

@julinvictus
Copy link
Contributor

@julinvictus julinvictus commented Oct 23, 2024

What does this PR do? What is the motivation?

According to doc
https://docs.datadoghq.com/real_user_monitoring/mobile_and_tv_monitoring/setup/flutter/#automatically-track-resources

correct param is traceSampleRate

Merge instructions

  • Please merge after reviewing

Additional notes

@julinvictus julinvictus requested a review from a team as a code owner October 23, 2024 18:21
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update!

@rtrieu
Copy link
Contributor

rtrieu commented Oct 23, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 23, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Oct 23, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@julinvictus
Copy link
Contributor Author

@fuzzybinary @rtrieu is there anything wrong with Synth test step? I rebased several times and didn't work (also in another PR)

@rtrieu
Copy link
Contributor

rtrieu commented Oct 28, 2024

Hi @julinvictus, the reason the check is not passing is because the branch name does not follow the required naming convention that creates a preview branch. The branch simply needs a / in it in order for the GitLab pipeline to run - something to keep in mind for next time :) I have copied your changes to another branch and will close this one!

@rtrieu rtrieu closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants