Skip to content

Update watchdog_explains.md #26167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phishindsn wants to merge 1 commit into from
Closed

Update watchdog_explains.md #26167

phishindsn wants to merge 1 commit into from

Conversation

@phishindsn
Copy link

@phishindsn phishindsn commented Nov 7, 2024

Typo in the first description of Watchdog Explains

What does this PR do? What is the motivation?

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@phishindsn
Update watchdog_explains.md
0c5c77b 
Typo in the first description of Watchdog Explains
@phishindsn phishindsn requested a review from a team as a code owner November 7, 2024 14:53
git-thuerk-done
git-thuerk-done approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@git-thuerk-done git-thuerk-done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, looks good

@git-thuerk-done
Copy link
Contributor

git-thuerk-done commented Nov 7, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 7, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-07 19:19:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-07 23:19:21 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@git-thuerk-done
Copy link
Contributor

git-thuerk-done commented Nov 7, 2024

Hi @phishindsn actually can you close this PR and re-open it with the proper branch name (yourname/update-watchdog)? The reason is the checks won't pass with the current branch name and then we aren't able to merge it. Thanks!

@git-thuerk-done
Copy link
Contributor

git-thuerk-done commented Dec 4, 2024

replaced by #26606

@git-thuerk-done git-thuerk-done deleted the phishindsn-patch-1 branch December 4, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@git-thuerk-done git-thuerk-done git-thuerk-done approved these changes

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phishindsn @git-thuerk-done