Skip to content

CSM without infra monitoring - apply Rajat's edits #26466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
janine-c wants to merge 3 commits into from
Closed

CSM without infra monitoring - apply Rajat's edits #26466

janine-c wants to merge 3 commits into from

Conversation

@janine-c
Copy link
Contributor

@janine-c janine-c commented Nov 23, 2024

What does this PR do? What is the motivation?

Follow up to #26381

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@janine-c janine-c requested a review from a team as a code owner November 23, 2024 00:10
@janine-c janine-c mentioned this pull request Nov 23, 2024
Merged
estherk15
estherk15 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an optional suggestion, approved!

content/en/security/cloud_security_management/setup/without_infrastructure_monitoring.md
1. To turn off infrastructure monitoring, under the selected account number, on the **Metric Collection** tab, click the **disable metric collection** link. Then, click **Disable Metric Collection** to confirm.

If you don't see the required account, add it by clicking **Add AWS Account(s)** and following the onscreen prompts.
1. To turn off infrastructure monitoring on a given account, under the selected account number, on the **Metric Collection** tab, click the **disable metric collection** link. Then, click **Disable Metric Collection** to confirm.
Copy link
Contributor

@estherk15 estherk15 Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. To turn off infrastructure monitoring on a given account, under the selected account number, on the **Metric Collection** tab, click the **disable metric collection** link. Then, click **Disable Metric Collection** to confirm.
1. To turn off infrastructure monitoring, under the selected account number, in the **Metric Collection** tab, click the **disable metric collection** link. Then, click **Disable Metric Collection** to confirm.

rajat-luthra-ddog
rajat-luthra-ddog approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@rajat-luthra-ddog rajat-luthra-ddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this page will only list for AWS and not Azure and GCP in this PR.

@janine-c
Copy link
Contributor Author

janine-c commented Nov 26, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 26, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-26 16:35:22 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-11-26 18:34:36 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@janine-c
Copy link
Contributor Author

janine-c commented Nov 26, 2024

/merge -c

@janine-c janine-c closed this Nov 26, 2024
@janine-c janine-c deleted the janine.chan-docs-9522-csm-without-infra-monitoring-edits branch November 26, 2024 18:44
@janine-c
Copy link
Contributor Author

janine-c commented Nov 26, 2024

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Nov 26, 2024

Devflow running: /merge -c

View all feedbacks in Devflow UI.

2024-11-26 18:44:36 UTC ❌ Devflow: /merge -c

This merge request was already processed and can't be unqueued anymore.

To get help about command usage, write /merge --help

If you need support, contact us on Slack #devflow with those details!

@janine-c
Copy link
Contributor Author

janine-c commented Nov 26, 2024

Renaming branch so merge works this time 🙃

@janine-c janine-c mentioned this pull request Nov 26, 2024
Merged
@janine-c
Copy link
Contributor Author

janine-c commented Nov 26, 2024

See #26502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estherk15 estherk15 estherk15 approved these changes

+1 more reviewer

@rajat-luthra-ddog rajat-luthra-ddog rajat-luthra-ddog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janine-c @estherk15 @rajat-luthra-ddog