Update sql_deadlock.md #26618
Merged
Update sql_deadlock.md #26618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Preview links (active after the
|
nenadnoveljic
approved these changes
Dec 5, 2024
neko-dd
reviewed
Dec 5, 2024
Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>
Co-authored-by: Sandra (neko) <165049174+neko-dd@users.noreply.github.com>
Contributor
Author
|
Hi @neko-dd , thanks, makes sense to me. I definitely think the main issue was the DBM setup requirement line was within a paragraph that's easily skipped, so this helps. |
neko-dd
approved these changes
Dec 9, 2024
Contributor
Author
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Adds a bit of extra clarity to the SQL Server deadlock guide concerning the need to having dbm setup
Motivation is from a customer question here: https://dd.slack.com/archives/C027TGQFUMR/p1733389297042209
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes