Skip to content

Conversation

@KevinLalor
Copy link
Contributor

What does this PR do? What is the motivation?

Changing APM to APM Metrics to make it more clear that Trace Analytics and Watchdog APM type monitors are not supported.

Merge instructions

Merge readiness:

  • [Yes] Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Changing APM to APM Metrics to make it more clear that Trace Analytics and Watchdog APM type monitors are not supported.
@KevinLalor KevinLalor requested a review from a team as a code owner December 12, 2024 16:02
@KevinLalor
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 12, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-12 16:03:33 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-12 20:03:36 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@michaelcretzman
Copy link
Contributor

@KevinLalor Hey, our repo contribution guidelines require that you name your branch with the convention slack_username/branch_name.

If you don't include the forward slash (/), the Gitlab pipeline won't run and you won't get a branch preview. Getting a branch preview makes it easier for us to check for any issues with your PR, such as broken links.

To find your Slack username, see https://www.highviewapps.com/kb/how-do-i-find-my-slack-username/.
To rename your branch, go to https://github.com/DataDog/documentation/branches, find this branch, and then select ... and Rename branch.

Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a branch name that matches our requirements. see earlier comment

@KevinLalor KevinLalor closed this Dec 16, 2024
@KevinLalor KevinLalor deleted the KevinLalor-AlertGraphWidget-Small-Change branch December 16, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants