Skip to content

Conversation

@willstrickfaden
Copy link
Contributor

Update setRemoteSampleRate parameter default value for all logs to 100f from 1.0 to match the sdk.

What does this PR do? What is the motivation?

Updating outdated / now incorrect documentation.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Update setRemoteSampleRate parameter default value for all logs to 100f from 1.0 to match the sdk.
@willstrickfaden willstrickfaden requested review from a team as code owners February 6, 2025 21:55
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@estherk15
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 7, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-07 15:05:23 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-07 19:06:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@estherk15 estherk15 merged commit 4a4d22b into master Feb 7, 2025
9 checks passed
@estherk15 estherk15 deleted the willstrickfaden-patch-1 branch February 7, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants