Skip to content

Update private_location.md #27738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 3 commits into from
Mar 28, 2025
Merged

Update private_location.md #27738

dd-mergequeue merged 3 commits into from
Mar 28, 2025

Conversation

@thang62590
Copy link
Contributor

@thang62590 thang62590 commented Feb 20, 2025

Add content about private locations being only supported on amd64 architecture

@thang62590
Update private_location.md
4650120 
Add content about private locations being only supported on amd64 architecture
@thang62590 thang62590 requested a review from a team as a code owner February 20, 2025 23:19
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025

Preview links (active after the build_preview check completes)

Modified Files

buraizu
buraizu requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some minor updates per the style guide, and also to have the note render on a new line, as currently it's a bit confusing to have the note placed immediately after the asterisk. Screenshot for reference:
before_space

@thang62590 @buraizu
Update content/en/getting_started/synthetics/private_location.md
bb3e065 
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
@thang62590
Copy link
Contributor Author

thang62590 commented Mar 26, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 26, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-03-26 13:53:18 UTC ℹ️ Start processing command /merge

2025-03-26 13:53:31 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-03-26 17:54:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@thang62590
Copy link
Contributor Author

thang62590 commented Mar 28, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-03-28 13:31:35 UTC ℹ️ Start processing command /merge

2025-03-28 13:31:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 17m (p90).

2025-03-28 13:46:36 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 8fd3e3c into master Mar 28, 2025
17 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the thang.nguyen/pl-amd64-support branch March 28, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buraizu buraizu buraizu approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thang62590 @buraizu