Skip to content

Conversation

@jhjacobson
Copy link
Contributor

Clarifying that containers can be billable per customer's feedback

What does this PR do? What is the motivation?

a customer pointed out that containers can actually be billable as documented here. They asked if we could clarify that this is the case given that we call out custom metrics as billable.

Merge instructions

I'm not sure if this will be more confusing since it isn't always the case that it's billable. But containers have an allotment similar to custom metrics so it seems fair to call it out here.
Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Clarifying that containers can be billable per lululemon's feedback
@jhjacobson jhjacobson requested a review from a team as a code owner February 25, 2025 13:39
@maycmlee maycmlee self-assigned this Feb 25, 2025
@maycmlee
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 25, 2025

View all feedbacks in Devflow UI.
2025-02-25 18:41:56 UTC ℹ️ Start processing command /merge


2025-02-25 18:42:02 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-25 22:43:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@maycmlee
Copy link
Contributor

Thanks @jhjacobson for opening this PR! I opened a new PR with the correct branch naming format (<your_name>/<branch_name>): #28116, so will close this one.

@maycmlee maycmlee closed this Mar 12, 2025
@maycmlee maycmlee deleted the jhjacobson-containers-clarification branch March 12, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants