Skip to content

Conversation

@u-kai
Copy link
Contributor

@u-kai u-kai commented Mar 2, 2025

What does this PR do? What is the motivation?

This PR fixes a minor typo in the documentation.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

No additional changes were made apart from fixing the typo.

@u-kai u-kai requested review from a team as code owners March 2, 2025 06:11
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the docs!

@rtrieu
Copy link
Contributor

rtrieu commented Mar 3, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 3, 2025

View all feedbacks in Devflow UI.
2025-03-03 15:20:53 UTC ℹ️ Start processing command /merge


2025-03-03 15:20:57 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-03 19:21:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@u-kai
Copy link
Contributor Author

u-kai commented Mar 3, 2025

Thank you for reviewing!

@u-kai
Copy link
Contributor Author

u-kai commented May 21, 2025

@hannahqjiang @rtrieu
Hi, I saw that this PR has been approved, but it hasn’t been merged yet.
Is there anything else I need to do on my end?

Thanks!

@rtrieu
Copy link
Contributor

rtrieu commented May 22, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 22, 2025

View all feedbacks in Devflow UI.

2025-05-22 17:26:49 UTC ℹ️ Start processing command /merge


2025-05-22 17:27:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-22 21:27:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@rtrieu
Copy link
Contributor

rtrieu commented May 22, 2025

Hi @ukai, I'm not sure what happened the first time, but I'm going to try merging this again. Let me know if you notice anything strange! Thanks.

@rtrieu
Copy link
Contributor

rtrieu commented May 22, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 22, 2025

View all feedbacks in Devflow UI.

2025-05-22 20:21:41 UTC ℹ️ Start processing command /merge


2025-05-22 20:21:45 UTC ❌ MergeQueue

PR already in the queue with status waiting

@u-kai
Copy link
Contributor Author

u-kai commented May 22, 2025

@rtrieu
Post preview link workflow is failing with a 403 Resource not accessible by integration error when trying to post a comment using create-or-update-comment.

What's strange is that this issue doesn't happen in other PRs—the same workflow works fine elsewhere.
The workflow explicitly sets:

permissions:
  contents: read
  pull-requests: write

But according to the Actions runner logs, only has pull-requests: read at runtime.

Set up job
Current runner version: '2.324.0'
Operating System
Runner Image
Runner Image Provisioner
GITHUB_TOKEN Permissions
  Contents: read
  Metadata: read
  PullRequests: read
Secret source: None
Prepare workflow directory
Prepare all required actions
Getting action download info
...

If anyone has insights or ideas, I'd really appreciate your help.

Thanks!

@rtrieu
Copy link
Contributor

rtrieu commented May 29, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 29, 2025

View all feedbacks in Devflow UI.

2025-05-29 15:09:08 UTC ℹ️ Start processing command /merge


2025-05-29 15:09:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-29 17:04:28 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@rtrieu rtrieu merged commit fe37177 into DataDog:master May 29, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants