[CONTP-705][integrations] Document 'check_tag_cardinality' #28691
Conversation
zhuminyi
changed the title
zhuminyi
changed the title
| # Rest of the config here | ||
| ``` | ||
| You can override the global Agent-level tag cardinality for a specific check using the check_tag_cardinality configuration option. This allows you to control the level of tag granularity used for that particular check, regardless of the global setting. |
There was a problem hiding this comment.
Thanks for adding this! I’m a little unsure about including check_tag_cardinality in this section as-is—it feels a bit advanced relative to the rest of the content, and the section is getting a bit long and dense.
I'm wondering if it would be worth splitting the Tagging section into three sub-sections:
- Global Tags (covers datadog.yaml, env, service)
- Autodiscovered Tags (covers container/environment tags and ignore_autodiscovery_tags)
- Advanced: Controlling Tag Cardinality (introduces check_tag_cardinality and how it overrides the global setting)
Alternatively, we can put the advanced stuff somewhere else and then simply link to that. Are all the advanced config options defined in GitHub somewhere? In the code? We often do this -- we provide the basic config in the public docs and then link to a yaml file somewhere (for example) that defines all the options.
Thoughts?
zhuminyi
force-pushed
the
CONTP-705-add-check_tag_cardinality
branch
from
b5babcc to
f0aef6d
Compare
zhuminyi
force-pushed
the
CONTP-705-add-check_tag_cardinality
branch
2 times, most recently
from
60d4f8b to
65dd294
Compare
zhuminyi
force-pushed
the
CONTP-705-add-check_tag_cardinality
branch
from
65dd294 to
90009b2
Compare
domalessi
left a comment
domalessi
left a comment
There was a problem hiding this comment.
A few formatting tweaks. Otherwise, looks great!
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
dd-devflow
bot
added
mergequeue-status: waiting
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
|
@zhuminyi I'm closing this PR in favor of this one: #28886 We require a specific branch name syntax for all our checks to run. We can force merge this, but I'd prefer playing it safe and just recreating under a different branch name :) |
What does this PR do? What is the motivation?
Documents the check_tag_cardinality option that was introduced here: DataDog/datadog-agent#29984
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes